This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
feat: Handle Stripe webhooks payment received for DPM order fulfillment #4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianajlk
force-pushed
the
julianajlk/REV-3973/use-webhooks-for-dpm-bnpl
branch
16 times, most recently
from
481531e
to
32d72d2
Compare
julianajlk
force-pushed
the
julianajlk/REV-3973/use-webhooks-for-dpm-bnpl
branch
from
32d72d2
to
901f9bf
Compare
|
|
||
| @property | ||
| def payment_processor(self): | ||
| return Stripe(self.site) |
There was a problem hiding this comment.
Repeating back here to make sure I understand what we chatted about, but basically this payment_processor method is here because the payment processor this class uses is Stripe, BUT we don't use the other payment processor class because we we require different functionality than synchronous purchases (and the things that behave differently are overridden below)
There was a problem hiding this comment.
I think I added this here because somewhere in the code it references the same of the processor, which we want it to be Stripe and not the StripeWebhooksPayment. I will get back to you where.
julianajlk
force-pushed
the
julianajlk/REV-3973/use-webhooks-for-dpm-bnpl
branch
3 times, most recently
from
93705ee
to
585d670
Compare
julianajlk
force-pushed
the
julianajlk/REV-3973/use-webhooks-for-dpm-bnpl
branch
2 times, most recently
from
ea669c6
to
41ec2ed
Compare
julianajlk
force-pushed
the
julianajlk/REV-3973/use-webhooks-for-dpm-bnpl
branch
4 times, most recently
from
b8221e0
to
22bc6b7
Compare
julianajlk
force-pushed
the
julianajlk/REV-3973/use-webhooks-for-dpm-bnpl
branch
from
22bc6b7
to
e7b43bd
Compare
christopappas
approved these changes
Apr 12, 2024
julianajlk
force-pushed
the
julianajlk/REV-3973/use-webhooks-for-dpm-bnpl
branch
from
54a3d5a
to
6335635
Compare
julianajlk
force-pushed
the
julianajlk/REV-3973/use-webhooks-for-dpm-bnpl
branch
from
18f27eb
to
1abc1ba
Compare
julianajlk
force-pushed
the
julianajlk/REV-3973/use-webhooks-for-dpm-bnpl
branch
from
1abc1ba
to
b51172c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REV-3973.
Order creation, fulfillment, billing address creation must be addressed via webhook events for Dynamic Payment Methods.
Adding a WebhooksPayment class to handle all that is needed after a payment is successfully received.
Redirect to receipt URL will happen via payment MFE redirect.
This PR also adds/updates the receipt error page to include a message specific for DPM.