This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
feat: Merged basket creation and checkout in one View #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +11,7 @@ | |||
| ) | |||
|
|
|||
| urlpatterns = [ | |||
| url(r'^basket-checkout/$', BasketCheckoutView.as_view(), name='mobile-basket-checkout'), | |||
There was a problem hiding this comment.
Looks like many of the other mobile view are prefixed with Mobile, should this on be as well?
| basket = prepare_basket(request, available_products) | ||
| except AlreadyPlacedOrderException: | ||
| logger.exception(LOGGER_BASKET_ALREADY_PURCHASED, request.user.username, skus) | ||
| return JsonResponse({'error': _(ERROR_ALREADY_PURCHASED)}, status=status.HTTP_406_NOT_ACCEPTABLE) |
There was a problem hiding this comment.
Can we add a test to cover this path?
I think we might need another one for line 206/211 as well
There was a problem hiding this comment.
These lines are already covered since new test case class is inheriting MobileBasketAddItemsViewTests class.
There was a problem hiding this comment.
interesting. i didn't expect the inheritance to behave that way. that's neat
christopappas
approved these changes
May 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH
⛔️ DEPRECATION WARNING
This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.
Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to [email protected]
Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
Required Testing
(^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)
Description
Merged basket creation and checkout in one View. This view will now accept product sku and payment processor name and will return a checkout out basket id. After this call we can now move on with payment execution.
Supporting information
https://2u-internal.atlassian.net/browse/LEARNER-9913
Testing instructions
Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?
Other information
Include anything else that will help reviewers and consumers understand the change.