Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

feat!: remove Transifex calls for OEP-58 | FC-0012 #142

Conversation

hopewise
Copy link
Contributor

@hopewise hopewise commented Oct 14, 2023

Breaking change!

This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.

Changes

  • Removes all direct use of tx pull and tx push commands from the micro-frontend in favor
    of the atlas pull command.
  • Remove source and language translations from the repositories, hence no .json files will be committed into the repos.
  • src/i18n/index.js should export and empty array so the make pull_translations override it with the dynamic list of languages.
  • Remove the experimental OPENEDX_ATLAS_PULL flag to make atlas pull the default.
  • Remove all Transifex related Makefile targets and other files.

Test results

  • Verify that make pull_translations works as expected.
make pull_translations test results
# I've run the following commands:
$ make requirements
$ make pull_translations
$ git diff

# Output of the commmands:

make pull_translations
rm -rf src/i18n/messages
mkdir src/i18n/messages
cd src/i18n/messages \
      && atlas pull \
               translations/frontend-component-footer/src/i18n/messages:frontend-component-footer \
               translations/frontend-component-header/src/i18n/messages:frontend-component-header \
               translations/paragon/src/i18n/messages:paragon \
               translations/frontend-app-account/src/i18n/messages:frontend-app-program-manager
Pulling translation files
 - directory: translations/frontend-component-footer/src/i18n/messages:frontend-component-footer translations/frontend-component-header/src/i18n/messages:frontend-component-header translations/paragon/src/i18n/messages:paragon translations/frontend-app-account/src/i18n/messages:frontend-app-program-manager
 - repository: openedx/openedx-translations
 - branch: main
 - filter: Not Specified
 - expand-glob: Not Specified
Creating a temporary Git repository to pull translations into "./translations_TEMP"...
Done.
Setting git sparse-checkout rules...
Done.
Pulling translation files from the repository...
remote: Enumerating objects: 37, done.
remote: Counting objects: 100% (37/37), done.
remote: Compressing objects: 100% (24/24), done.
remote: Total 37 (delta 20), reused 26 (delta 13), pack-reused 0
Receiving objects: 100% (37/37), 156.34 KiB | 498.00 KiB/s, done.
Resolving deltas: 100% (20/20), done.
Updating files: 100% (37/37), done.
Your branch is up to date with 'origin/main'.
Done.
Copying translations from "./translations_TEMP/translations/frontend-component-footer/src/i18n/messages" to "./frontend-component-footer"...
Done.
Copying translations from "./translations_TEMP/translations/frontend-component-header/src/i18n/messages" to "./frontend-component-header"...
Done.
Copying translations from "./translations_TEMP/translations/paragon/src/i18n/messages" to "./paragon"...
Done.
Copying translations from "./translations_TEMP/translations/frontend-app-account/src/i18n/messages" to "./frontend-app-program-manager"...
Done.
Removing temporary directory...
Done.

Translations pulled successfully!
./node_modules/.bin/intl-imports.js frontend-component-header frontend-component-footer paragon frontend-app-program-manager

Merge timeline

This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.

The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.

Keep this pull request as a draft to prevent accidental merge.

Pre-merge checklist

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 14, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 14, 2023

Thanks for the pull request, @hopewise! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.22%. Comparing base (240cd79) to head (968d960).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   58.08%   58.22%   +0.14%     
==========================================
  Files          26       25       -1     
  Lines         396      395       -1     
  Branches       66       66              
==========================================
  Hits          230      230              
+ Misses        150      149       -1     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 17, 2023
@itsjeyd itsjeyd added the blocked by other work PR cannot be finished until other work is complete label Nov 2, 2023
@itsjeyd itsjeyd removed the blocked by other work PR cannot be finished until other work is complete label Feb 23, 2024
@hopewise hopewise marked this pull request as ready for review March 14, 2024 07:11
@OmarIthawi OmarIthawi force-pushed the samir/frontend-app-program-console branch from 372180e to 4e9a2f0 Compare March 17, 2024 11:33
@OmarIthawi
Copy link
Contributor

OmarIthawi commented Mar 17, 2024

@timmc-edx @brian-smith-tcril this is ready for merge and has 👍🏼 from 2U.

@OmarIthawi OmarIthawi force-pushed the samir/frontend-app-program-console branch from 4e9a2f0 to 968d960 Compare March 17, 2024 11:36
@coveralls
Copy link

coveralls commented Mar 17, 2024

Pull Request Test Coverage Report for Build 8315107757

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 55.473%

Totals Coverage Status
Change from base Build 7834809181: 0.1%
Covered Lines: 168
Relevant Lines: 305

💛 - Coveralls

@brian-smith-tcril brian-smith-tcril merged commit 14b2a51 into openedx-unsupported:master Mar 18, 2024
7 checks passed
@openedx-webhooks
Copy link

@hopewise 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants