Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

build: Upgrade to Node 20 #194

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jul 25, 2024

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

Second step in the Node 20 upgrade process, See the tracking issue for futher information.

@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/node-v20-upgrade branch from ddb6fbb to e790268 Compare July 25, 2024 09:05
@coveralls
Copy link

coveralls commented Jul 25, 2024

Pull Request Test Coverage Report for Build 10696172814

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.473%

Totals Coverage Status
Change from base Build 10682249669: 0.0%
Covered Lines: 168
Relevant Lines: 305

💛 - Coveralls

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.22%. Comparing base (9a1eab6) to head (a0c3b15).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   58.22%   58.22%           
=======================================
  Files          25       25           
  Lines         395      395           
  Branches       66       66           
=======================================
  Hits          230      230           
  Misses        149      149           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as draft July 25, 2024 12:55
@BilalQamar95 BilalQamar95 marked this pull request as ready for review August 9, 2024 10:50
@BilalQamar95 BilalQamar95 marked this pull request as draft August 21, 2024 08:43
@BilalQamar95
Copy link
Contributor Author

PR will be updated and ready for review once the prerequisite PR for first step of the node v20 upgrade process is merged.

@BilalQamar95 BilalQamar95 mentioned this pull request Sep 4, 2024
@BilalQamar95 BilalQamar95 changed the title feat: updated node to v20 build: Upgrade to Node 20 Sep 4, 2024
@BilalQamar95 BilalQamar95 self-assigned this Sep 4, 2024
@BilalQamar95 BilalQamar95 marked this pull request as ready for review September 4, 2024 06:19
@brian-smith-tcril brian-smith-tcril merged commit db01cde into master Sep 6, 2024
7 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/node-v20-upgrade branch September 6, 2024 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants