fix: add trans filter to html templates

[Ian2012]

Description

This PR makes the translation fixes mentioned here: eduNEXT#3 (comment)

[openedx-webhooks]

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[Ian2012]

@OmarIthawi here is the PR. Are these changes sufficient enough?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3eababa) 90.78% compared to head (de51e56) 90.84%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   90.78%   90.84%   +0.06%     
==========================================
  Files           1        2       +1     
  Lines         141      142       +1     
==========================================
+ Hits          128      129       +1     
  Misses         13       13              

Flag	Coverage Δ
unittests	90.84% <100.00%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[OmarIthawi]

Much better. Thanks @Ian2012.

Please let me know whenever the translation PR is ready.

[Ian2012]

@OmarIthawi I think we should merge this first so that the messages files in openedx-translations gets updated. Once the translations are added to the repo, I will open the new PR

[OmarIthawi]

@Ian2012 I can't review this pull request at the moment. I think it has few anti-patterns that could be problematic in terms of the i18n e.g.

Most text should be translated directly within the templates instead of the Python files.

@mphilbrick211 would you mind tagging someone else for reviewing?

[feanil]

@farhan @thezaeemaanwar can you review this PR. This page might be helpful: https://docs.openedx.org/en/latest/translators/references/index.html

[feanil]

@OmarIthawi are there other resources you can provide to remove the anti-patterns in this PR?

[OmarIthawi]

@Ian2012 I can't review this pull request at the moment. I think it has few anti-patterns that could be problematic in terms of the i18n e.g.

Most text should be translated directly within the templates instead of the Python files.

@mphilbrick211 would you mind tagging someone else for reviewing?

@OmarIthawi are there other resources you can provide to remove the anti-patterns in this PR?

@feanil @Ian2012 that might be the only one I found. Sorry my earlier comment wasn't very specific.

Before I give a good feedback I need to review the whole XBlock and then give a recommendation, which is out of my time at the moment.

I recommend checking i18n at https://github.com/openedx/xblock-drag-and-drop-v2 and https://github.com/openedx/edx-ora2/ and see the patterns there and copy what applies.

Nevertheless, I don't see any blockers to this pull request.

[farhan]

Query and a change request rest all seems ok

[Ian2012]

@farhan can you review again?

[farhan]

👍

[farhan]

@Ian2012 approved, let me know when PR is ready to merge.
Squash the commits if you want else I will squash and merge it.

[Ian2012]

@farhan ready. Thanks for your review

[openedx-webhooks]

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.