feat: valid S3 expiration time

openedx · Dec 18, 2023 · 0aabd0a · 0aabd0a
1 parent d32e7e4
commit 0aabd0a
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/recommender/recommender.py b/recommender/recommender.py
@@ -285,7 +285,10 @@ def _get_onetime_url(self, filename):
         We benchmarked this as less than 8ms on a sandbox machine.
         """
         if filename.startswith('fs://'):
-            return str(self.fs.get_url(filename.replace('fs://', ''), 1000 * 60 * 60 * 10))
+            # 604800 seconds is the maximum allowed expiration by S3.
+            # If this is instead filesystem-backed, the timeout argument has
+            # no effect.
+            return str(self.fs.get_url(filename.replace('fs://', ''), 604800))
         else:
             return filename