Update setup.py, adds required packages #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhan
force-pushed
the
farhan/update-package-dependencies
branch
from
fa6bc63 to
951b00c
Compare
ormsbee
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding required package dependencies in the setup.py file after syncing it up with base.in
root cause found after the following test case failure:
https://github.com/openedx/DoneXBlock/actions/runs/6433150390/job/17469600711?pr=178#step:6:41
Ideally, we should add all the base.in packages in the
install_requiresofsetup.pyby code like this, can do it next PR.