feat!: annotate types #761
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kdmccormick
force-pushed
the
kdmccormick/types2
branch
5 times, most recently
from
343f88d to
414973e
Compare
kdmccormick
force-pushed
the
kdmccormick/types2
branch
from
414973e to
692f00b
Compare
kdmccormick
force-pushed
the
kdmccormick/types2
branch
from
692f00b to
de92e7a
Compare
kdmccormick
force-pushed
the
kdmccormick/types2
branch
from
de92e7a to
87d341b
Compare
kdmccormick
force-pushed
the
kdmccormick/types2
branch
2 times, most recently
from
0dbf212 to
c091774
Compare
kdmccormick
force-pushed
the
kdmccormick/types2
branch
2 times, most recently
from
7103af6 to
0330c66
Compare
_AutoNamedFieldsMetaclass was a hand-rolled way of capturing each Field's name as it is defined on an XBlock. Since Python 3.6, __set_name__ is part of the built-in Descriptor interface, providing a more elegant way of achieving the same thing.
Without --keep-going, 'make html' showed a single error at a time. With --keep-going, 'make html' shows them all in one big list. (Either way, the build would fail if there are any warnings, as desired.)
WIP: annotate xblock/runtime.py WIP: remove XBlock mixin from hierarchy, just use asserts, for backcompat? WIP: DEPR non-string usage and definition keys? BREAKING CHANGE: [Developers only] Type-checked Python code using the XBlock API will likely need to be updated in order to continue passing type-checking, since XBlock's new annotations will trigger mypy (et al) to behave much more strictly. NO BREAKING CHANGES for site operators, authors, learners, etc.
kdmccormick
force-pushed
the
kdmccormick/types2
branch
from
0330c66 to
b576acd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Will supersede #713
Test sandbox: openedx/edx-platform#35236