fix: remove unit test that fails with final keyword

openedx · Oct 17, 2024 · 3c80b70 · 3c80b70
1 parent b889ef2
commit 3c80b70
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 31 deletions.
diff --git a/models/grading/fact_student_status.sql b/models/grading/fact_student_status.sql
@@ -13,7 +13,7 @@ select
     users.name as name,
     users.email as email,
     fes.emission_time as enrolled_at
-from {{ ref("fact_enrollment_status") }} fes final
+from {{ ref("fact_enrollment_status") }} fes FINAL
 left join
     {{ ref("fact_learner_course_status") }} lg
     on fes.org = lg.org

diff --git a/models/grading/unit_tests.yaml b/models/grading/unit_tests.yaml
@@ -38,33 +38,3 @@ unit_tests:
     expect:
       format: csv
       fixture: fact_learner_course_status_expected
-
-  - name: test_fact_student_status
-    model: fact_student_status
-    config:
-      tags: 'ci'
-    given:
-      - input: ref('fact_enrollment_status')
-        format: sql
-        rows: |
-          select * from fact_enrollment_status
-      - input: ref('fact_learner_course_status')
-        format: sql
-        rows: |
-          select * from fact_learner_course_status
-      - input: ref('fact_learner_course_grade')
-        format: sql
-        rows: |
-          select * from fact_learner_course_grade
-      - input: ref('course_names')
-        format: sql
-        rows: |
-          select * from course_names
-      - input: ref('dim_user_pii')
-        format: sql
-        rows: |
-          select * from dim_user_pii
-    expect:
-      format: sql
-      rows: |
-        select * from fact_student_status_expected