Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use name with location as link text #120

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix: use name with location as link text #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95d9c41
fix: use name with location as link text
Ian2012 Sep 9, 2024
a1cae36
test: update seeds values
Ian2012 Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion models/problems/fact_problem_responses.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ select
responses.problem_id as problem_id,
blocks.block_name as problem_name,
blocks.display_name_with_location as problem_name_with_location,
{{ a_tag("responses.object_id", "blocks.block_name") }} as problem_link,
{{ a_tag("responses.object_id", "blocks.display_name_with_location") }}
as problem_link,
blocks.graded as graded,
course_order as course_order,
responses.actor_id as actor_id,
Expand Down
3 changes: 2 additions & 1 deletion models/problems/int_problem_results.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ select
blocks.block_name as problem_name,
blocks.display_name_with_location as problem_name_with_location,
blocks.course_order as course_order,
{{ a_tag("full_responses.object_id", "blocks.block_name") }} as problem_link,
{{ a_tag("full_responses.object_id", "blocks.display_name_with_location") }}
as problem_link,
full_responses.actor_id as actor_id,
full_responses.responses as responses,
full_responses.success as success,
Expand Down
3 changes: 2 additions & 1 deletion models/problems/section_problem_engagement.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ with
responses.problem_id as problem_id,
blocks.block_name as problem_name,
blocks.display_name_with_location as problem_name_with_location,
{{ a_tag("responses.object_id", "blocks.block_name") }} as problem_link,
{{ a_tag("responses.object_id", "blocks.display_name_with_location") }}
as problem_link,
blocks.graded as graded,
course_order as course_order,
responses.actor_id as actor_id,
Expand Down
3 changes: 2 additions & 1 deletion models/problems/subsection_problem_engagement.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ with
responses.problem_id as problem_id,
blocks.block_name as problem_name,
blocks.display_name_with_location as problem_name_with_location,
{{ a_tag("responses.object_id", "blocks.block_name") }} as problem_link,
{{ a_tag("responses.object_id", "blocks.display_name_with_location") }}
as problem_link,
blocks.graded as graded,
course_order as course_order,
responses.actor_id as actor_id,
Expand Down
2 changes: 1 addition & 1 deletion models/video/fact_video_plays.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ select
plays.video_id as video_id,
blocks.block_name as video_name,
blocks.display_name_with_location as video_name_with_location,
{{ a_tag("plays.object_id", "blocks.block_name") }} as video_link,
{{ a_tag("plays.object_id", "blocks.display_name_with_location") }} as video_link,
blocks.graded as graded,
plays.video_position as video_position,
plays.video_duration as video_duration,
Expand Down
1,826 changes: 913 additions & 913 deletions unit-test-seeds/problems/fact_problem_responses_expected.csv
View file
Open in desktop

Large diffs are not rendered by default.

1,746 changes: 873 additions & 873 deletions unit-test-seeds/problems/int_problem_results_expected.csv
View file
Open in desktop

Large diffs are not rendered by default.

4,980 changes: 2,490 additions & 2,490 deletions unit-test-seeds/video/fact_video_plays_expected.csv
View file
Open in desktop

Large diffs are not rendered by default.