fix: dbt updates for course comparison #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraburns1
force-pushed
the
fix_mv_query
branch
from
47486cf to
eb6681d
Compare
saraburns1
changed the title
Ian2012
reviewed
Oct 17, 2024
| @@ -38,33 +38,3 @@ unit_tests: | |||
| expect: | |||
| format: csv | |||
| fixture: fact_learner_course_status_expected | |||
|
|
|||
| - name: test_fact_student_status | |||
There was a problem hiding this comment.
Why did you removed this test?
There was a problem hiding this comment.
It fails with the 'final' keyword, not sure how to handle it yet so i just got rid of it for now
Ian2012
reviewed
Oct 17, 2024
Ian2012
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent duplicate rows by using final keyword when querying fact_enrollment_status mv
Remove unit test that fails because of the final keyword (TBD how to avoid this)
Add video count from course sink instead of video sink