Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write MVs to xapi schema again #39

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

SoryRawyer
Copy link
Contributor

This change overrides the destination database for the materialized views that were once written to the xapi schema so that they can be written to the correct database again. Note: while database is the preferred term when it comes to dbt and ClickHouse, dbt does not seem to recognize database as a valid configuration parameter for model destinations, hence the use of the schema keyword argument in the config block.

This change also requires profiles.yml to pass prod as the target instead of dev. I have updated sample_profiles.yml to match the expected configuration. This also means that the profile in tutor-contrib-aspects will need to be updated as well.

This change overrides the destination database for the materialized
views that were once written to the `xapi` schema so that they can be
written to the correct database again.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 11, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmtcril bmtcril merged commit 27d9b81 into openedx:main Jan 12, 2024
2 checks passed
@openedx-webhooks
Copy link

@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bmtcril
Copy link
Contributor

bmtcril commented Jan 12, 2024

Released as v3.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants