feat!: Upgrade schema to use new Ralph 4.0 event column #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian2012
approved these changes
Jan 18, 2024
bmtcril
force-pushed
the
bmtcril/ralph_4
branch
from
87c6bc7 to
0f0dc5d
Compare
Ralph 3.x had both a JSON "event" column and an "event_str" text representation of the same data. 4.x drops the JSON column since it is unsupported and going to be removed from ClickHouse, and renames the text column to "event".
bmtcril
force-pushed
the
bmtcril/ralph_4
branch
from
84f1c1a to
954b1a9
Compare
|
@bmtcril is this ready for review? |
bmtcril
commented
Jan 29, 2024
| @@ -9,34 +9,34 @@ | |||
|
|
|||
| SELECT | |||
| event_id as event_id, | |||
| JSON_VALUE(event_str, '$.verb.id') as verb_id, | |||
| JSON_VALUE(event::String, '$.verb.id') as verb_id, | |||
There was a problem hiding this comment.
This cast is necessary for dbt to run these models against an empty table for some reason.
|
@Ian2012 this should be ready for review now. @SoryRawyer you might want to take a look too. This goes with this work: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ralph 3.x had both a JSON "event" column and an
"event_str" text representation of the same data. 4.x drops the JSON column since it is unsupported and going to be removed from ClickHouse, and renames the text column to "event".
Ralph 4.0.0 is in beta right now, this is just for preparing to upgrade and test the changes.