Upgrade to Ralph 4.0 #572
Upgrade to Ralph 4.0 #572
Conversation
bmtcril
force-pushed
the
bmtcril/ralph_4
branch
2 times, most recently
from
82fa68b to
741cc4a
Compare
| ) | ||
| op.execute( | ||
| f""" | ||
| DROP VIEW IF EXISTS {{ ASPECTS_XAPI_DATABASE }}.xapi_events_all_parsed_mv; |
There was a problem hiding this comment.
We can't operate on the table as long as this view exists. It doesn't matter on a clean install where the mv doesn't exist yet, but if someone ever upgraded from an older version they would need to re-run dbt to get this back. Right now that's potentially a very expensive operation, but I guess they'd have to run dbt as part of the upgrade anyway. I'm not aware of any reason why people would downgrade / upgrade alembic outside of development.
There was a problem hiding this comment.
This might be a good time to consider further squashing migrations and resetting the numbering, but I know @Ian2012 is already running some live services of this. 🤔
There was a problem hiding this comment.
I would need to consider this with my team
|
This PR is still a WIP, once the related dbt and xapi-db-load PRs land I'll pick it back up. It may require more work in the Superset datasets, I'm not sure yet. cc @SoryRawyer for context. |
bmtcril
force-pushed
the
bmtcril/ralph_4
branch
from
b44e959 to
053e7b3
Compare
Includes changes needed to support running against a Ralph 4.x schema.
bmtcril
force-pushed
the
bmtcril/ralph_4
branch
from
053e7b3 to
fded401
Compare
bmtcril
force-pushed
the
bmtcril/ralph_4
branch
from
ae2a9a9 to
1019834
Compare
bmtcril
force-pushed
the
bmtcril/ralph_4
branch
from
1019834 to
30816c5
Compare
Draft PR until Ralph 4 comes out of beta. Will need further cleanup and testing, as well as these prs to land first: