Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: partition all tables by year and month #42

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Jan 26, 2024

Description

This PR partitions almost all tables by year and month.

@openedx-webhooks
Copy link

openedx-webhooks commented Jan 26, 2024

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 26, 2024
@Ian2012 Ian2012 changed the title feat: partition xapi_events_all_parsed feat: partition all tables by year and month Jan 26, 2024
@Ian2012 Ian2012 force-pushed the cag/partition-tables branch 2 times, most recently from 4593663 to 2a409d3 Compare January 26, 2024 21:51
@Ian2012 Ian2012 requested a review from bmtcril January 26, 2024 21:52
@Ian2012 Ian2012 marked this pull request as ready for review January 26, 2024 21:53
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like one little issue, otherwise 👍

models/grading/grading_events.sql Outdated Show resolved Hide resolved
@Ian2012 Ian2012 force-pushed the cag/partition-tables branch from 806adbd to 00ff908 Compare January 30, 2024 15:33
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ian2012
Copy link
Contributor Author

Ian2012 commented Jan 30, 2024

@bmtcril should I bump version?

@bmtcril
Copy link
Contributor

bmtcril commented Jan 30, 2024

This one isn't version managed in code, we just bump the tag / release after merging.

@Ian2012 Ian2012 merged commit 3897b09 into main Jan 30, 2024
2 checks passed
@Ian2012 Ian2012 deleted the cag/partition-tables branch January 30, 2024 19:39
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants