Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove extra rules added to match browserslist best practices #18

Merged

Conversation

brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril
Copy link
Contributor Author

Bringing over today's slack conversation about this:

@adamstankiewicz: [clarification] Isn't it expected that expanding the browserslist support would start including polyfills/shims that weren't there before, for supporting additional browsers it previously didn't need to support?
Are we sure those "unnecessary backwards compatibility shims" aren't expected due to the updated config?

@brian-smith-tcril: It is expected, I think the question is if it's desired

@bradenmacdonald: Some new shims and/or CSS adaptions etc were expected but the extent surprised me. I didn't realize the expanded support would include such old targets that required essentially everything to be shimmed. In the icon files for example, there's more shims than code in each file. I don't think it's worth it, especially since we didn't have any actual reports/complaints of incompatibility that we're trying to solve.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's ditch the best practices. The cost is clearly not worth it.

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the churn here :p

@brian-smith-tcril brian-smith-tcril merged commit 86ce3ee into openedx:master Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants