-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0074] add support for optional trigger information #143
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c0a2d01
feat: support trigger by fields
mariajgrimaldi 549faa6
fix: add id to trigger section
mariajgrimaldi 4c4f976
refactor: generate trigger list for paths
mariajgrimaldi 934d155
fix: replace with importlib.resources
mariajgrimaldi 3cdf9f2
fix: address quality issues
mariajgrimaldi 98fbdf4
refactor: replace strong with paragraph
mariajgrimaldi a07eb00
fix: address quality issues
mariajgrimaldi 626d2a4
refactor: render triggers only when trigger fields are available
mariajgrimaldi f82bf19
refactor: drop path from trigger details for more maintainable approach
mariajgrimaldi cf2a65e
refactor: address quality errors and replace event triggered by
mariajgrimaldi 4e96039
refactor: address quality errors and replace event triggered by
mariajgrimaldi 3958852
docs: update changelog and bump library version
mariajgrimaldi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,4 @@ | |
Extensible tools for parsing annotations in codebases. | ||
""" | ||
|
||
__version__ = '2.1.0' | ||
__version__ = '2.2.0' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,14 @@ | ||
""" | ||
Expose contrib configuration file paths as Python variables, for use in 3rd-party utilities. | ||
""" | ||
import importlib.resources | ||
import os | ||
|
||
import importlib_resources | ||
|
||
FEATURE_TOGGLE_ANNOTATIONS_CONFIG_PATH = importlib_resources.files( | ||
FEATURE_TOGGLE_ANNOTATIONS_CONFIG_PATH = importlib.resources.files( | ||
"code_annotations") / os.path.join("contrib", "config", "feature_toggle_annotations.yaml") | ||
|
||
SETTING_ANNOTATIONS_CONFIG_PATH = importlib_resources.files( | ||
SETTING_ANNOTATIONS_CONFIG_PATH = importlib.resources.files( | ||
"code_annotations") / os.path.join("contrib", "config", "setting_annotations.yaml") | ||
|
||
OPENEDX_EVENTS_ANNOTATIONS_CONFIG_PATH = importlib_resources.files( | ||
OPENEDX_EVENTS_ANNOTATIONS_CONFIG_PATH = importlib.resources.files( | ||
"code_annotations") / os.path.join("contrib", "config", "openedx_events_annotations.yaml") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference: #135 (comment)