perf: optimizations for SortedModelSelect2Multiple.optgroups (#4538)

openedx · Jan 9, 2025 · c76a7af · c76a7af
1 parent f238b3e
commit c76a7af
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/course_discovery/apps/course_metadata/widgets.py b/course_discovery/apps/course_metadata/widgets.py
@@ -12,21 +12,17 @@ def optgroups(self, name, value, attrs=None):
         only support one main group (because that's all we need right now).
         """
         selected = []
-        unselected = []
         for index, (option_value, option_label) in enumerate(chain(self.choices)):
             is_selected = str(option_value) in value
-            subgroup = [self.create_option(name, option_value, option_label, is_selected, index, attrs=attrs)]
-            item = (None, subgroup, index)
             if is_selected:
+                subgroup = [self.create_option(name, option_value, option_label, is_selected, index, attrs=attrs)]
+                item = (None, subgroup, index)
                 selected.append(item)
-            else:
-                unselected.append(item)
 
         ordered = []
         for value_id in value:
             for item in selected:
                 if value_id == str(item[1][0]['value']):
                     ordered.append(item)
                     break
-
         return ordered