feat: add capabilty in queryset method to exclude hidden runs #4443
+98
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfaqShuaib09
force-pushed
the
afaq/prod-4177
branch
from
318a087 to
9fbb868
Compare
Ali-D-Akbar
approved these changes
Sep 12, 2024
...se_discovery/apps/course_metadata/management/commands/tests/test_populate_product_catalog.py
Show resolved
Hide resolved
AfaqShuaib09
force-pushed
the
afaq/prod-4177
branch
3 times, most recently
from
99142f7 to
852fcc6
Compare
| @@ -54,7 +54,12 @@ def available(self): | |||
| # By itself, the query performs a join across several tables and would return | |||
| # the id of the same course multiple times (a separate copy for each available | |||
| # seat in each available run). | |||
| ids = self.filter(enrollable & not_ended & marketable).values('id').distinct() | |||
| if exclude_hidden_runs: | |||
| # A CourseRun is "hidden" if it has a "hidden" attribute set to True. | |||
There was a problem hiding this comment.
There is no need for the comment here, the code is fairly obvious here.
AfaqShuaib09
force-pushed
the
afaq/prod-4177
branch
2 times, most recently
from
1b4f230 to
b6ea01d
Compare
AfaqShuaib09
force-pushed
the
afaq/prod-4177
branch
from
b6ea01d to
8715516
Compare
DawoudSheraz
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-4177
This PR adds the capability in
populate_product_catalogcommand to exclude hidden available runs from the queryset.Testing:
python manage.py populate_product_catalog --product_type={product_type} --output_csv=/path/to/output.csv --product_source={product_source}