Skip to content

Commit

Permalink
chore: fixing the stubs in the settings file for the log formatter
Browse files Browse the repository at this point in the history
this is an attempt to fix the overrides for the log formatter by putting
stubs in the settings files.
  • Loading branch information
deborahgu committed Dec 5, 2024
1 parent 311f38e commit 5d1f9b1
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
3 changes: 2 additions & 1 deletion credentials/settings/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,8 @@
ACE_CHANNEL_SAILTHRU_TEMPLATE_NAME = "" # unused, but required to be set or we see an exception

# Set up logging for development use (logging to stdout)
LOGGING = get_logger_config(debug=DEBUG, dev_env=True, local_loglevel="DEBUG")
LOGGING_FORMAT_STRING = ""
LOGGING = get_logger_config(debug=DEBUG, dev_env=True, local_loglevel="DEBUG", format_string=LOGGING_FORMAT_STRING)

# DRF Settings
REST_FRAMEWORK = {
Expand Down
3 changes: 2 additions & 1 deletion credentials/settings/devstack.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@

ALLOWED_HOSTS = ["*"]

LOGGING = get_logger_config(debug=True, dev_env=True, local_loglevel="DEBUG")
LOGGING_FORMAT_STRING = ""
LOGGING = get_logger_config(debug=True, dev_env=True, local_loglevel="DEBUG", format_string=LOGGING_FORMAT_STRING)
del LOGGING["handlers"]["local"]

SECRET_KEY = os.environ.get("SECRET_KEY", "change-me")
Expand Down
3 changes: 2 additions & 1 deletion credentials/settings/local.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@
USER_CACHE_TTL = 60

# LOGGING
LOGGING = get_logger_config(debug=True, dev_env=True, local_loglevel="DEBUG")
LOGGING_FORMAT_STRING = ""
LOGGING = get_logger_config(debug=True, dev_env=True, local_loglevel="DEBUG", format_string=LOGGING_FORMAT_STRING)

Check warning on line 60 in credentials/settings/local.py

View check run for this annotation

Codecov / codecov/patch

credentials/settings/local.py#L59-L60

Added lines #L59 - L60 were not covered by tests

#####################################################################
# Lastly, see if the developer has any local overrides.
Expand Down
3 changes: 2 additions & 1 deletion credentials/settings/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
"credentials.apps.edx_credentials_extensions",
]

LOGGING = get_logger_config(debug=False, dev_env=True, local_loglevel="DEBUG")
LOGGING_FORMAT_STRING = ""
LOGGING = get_logger_config(debug=False, dev_env=True, local_loglevel="DEBUG", format_string=LOGGING_FORMAT_STRING)
ALLOWED_HOSTS = ["*"]

DATABASES = {
Expand Down

0 comments on commit 5d1f9b1

Please sign in to comment.