-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: [FC-0002] Issue verifiable credentials to learners ADR #1846
docs: [FC-0002] Issue verifiable credentials to learners ADR #1846
Conversation
Thanks for the pull request, @GlugovGrGlib! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've proposed a couple small changes and posed a couple bigger questions. Overall I think both the ADRs are very strong, well researched, well documents, clearly written.
docs/decisions/0008-issue-verifiable-credentails-in-learner-records-mfe.rst
Outdated
Show resolved
Hide resolved
docs/decisions/0008-issue-verifiable-credentails-in-learner-records-mfe.rst
Outdated
Show resolved
Hide resolved
Hi @GlugovGrGlib! Just checking to see if the requested changes were made? Is this ready for review? |
@GlugovGrGlib friendly follow-up on this :) |
2b36806
to
1019ee9
Compare
* docs: verifiable credentials ADR * docs: ADR issue verifiable credentials in MFE * docs: update adrs numbering
* docs: verifiable credentials ADR * docs: ADR issue verifiable credentials in MFE * docs: update adrs numbering
In this ADR you will find a proposal to implement Verifiable Credentials sharing mechanism according to Verifiable Credentials design.
This ADR is proposed as a part of FC-0002 General Design for Sharing Open edX Credentials
Ticket: #1735
This PR depends on, and should be merged after: #1797