Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [FC-0002] Issue verifiable credentials to learners ADR #1846

Merged

Conversation

GlugovGrGlib
Copy link
Member

@GlugovGrGlib GlugovGrGlib commented Dec 4, 2022

In this ADR you will find a proposal to implement Verifiable Credentials sharing mechanism according to Verifiable Credentials design.

This ADR is proposed as a part of FC-0002 General Design for Sharing Open edX Credentials

Ticket: #1735

This PR depends on, and should be merged after: #1797

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 4, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @GlugovGrGlib! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

@e0d e0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've proposed a couple small changes and posed a couple bigger questions. Overall I think both the ADRs are very strong, well researched, well documents, clearly written.

@mphilbrick211 mphilbrick211 removed the open-source-contribution PR author is not from Axim or 2U label Dec 19, 2022
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 19, 2023
@mphilbrick211
Copy link

Hi @GlugovGrGlib! Just checking to see if the requested changes were made? Is this ready for review?

@mphilbrick211
Copy link

@GlugovGrGlib friendly follow-up on this :)

@hurtstotouchfire hurtstotouchfire self-assigned this Feb 27, 2023
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jul 17, 2023
@mphilbrick211 mphilbrick211 requested a review from a team July 17, 2023 22:51
@GlugovGrGlib GlugovGrGlib force-pushed the fc-0002/g-glugovskiy/vc-issuing-adr branch from 2b36806 to 1019ee9 Compare August 1, 2023 18:10
@GlugovGrGlib GlugovGrGlib merged commit e1904f2 into openedx:master Aug 1, 2023
@GlugovGrGlib GlugovGrGlib deleted the fc-0002/g-glugovskiy/vc-issuing-adr branch August 1, 2023 18:24
GlugovGrGlib added a commit to raccoongang/credentials that referenced this pull request Aug 1, 2023
* docs: verifiable credentials ADR

* docs: ADR issue verifiable credentials in MFE

* docs: update adrs numbering
GlugovGrGlib added a commit that referenced this pull request Aug 9, 2023
* docs: verifiable credentials ADR

* docs: ADR issue verifiable credentials in MFE

* docs: update adrs numbering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants