Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImagesTranslatingStrings #420

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

jesgreco
Copy link
Contributor

Adding 6 images to better describe the process of translating strings within Transifex.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 31, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 31, 2023

Thanks for the pull request, @jesgreco! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesgreco the images look useful, are you planning on including them in a document as well?

@jesgreco
Copy link
Contributor Author

jesgreco commented Nov 1, 2023

Yes, @feanil I want to include them in the document! Are you suggesting to combine this PR with the one containing the images? How can I proceed?

@feanil
Copy link
Contributor

feanil commented Nov 2, 2023

Yes, you should combine this PR with the one that uses these images.

@feanil feanil force-pushed the UploadImages_TranslatorsDoc branch from 071f3fe to 1e25c8a Compare November 7, 2023 15:47
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesgreco there were some syntax issues with how you added the images to the document, it looked like you tried to use markdown syntax instead of RST. There is an example of how to do it with RST here: https://docs.openedx.org/en/latest/documentors/references/quick_reference_rst.html#directives

For this PR, I made the correction so it should be all set.

@feanil feanil merged commit 81f67a7 into openedx:main Nov 7, 2023
@openedx-webhooks
Copy link

@jesgreco 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants