-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImagesTranslatingStrings #420
Conversation
Thanks for the pull request, @jesgreco! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jesgreco the images look useful, are you planning on including them in a document as well?
Yes, @feanil I want to include them in the document! Are you suggesting to combine this PR with the one containing the images? How can I proceed? |
Yes, you should combine this PR with the one that uses these images. |
071f3fe
to
1e25c8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jesgreco there were some syntax issues with how you added the images to the document, it looked like you tried to use markdown syntax instead of RST. There is an example of how to do it with RST here: https://docs.openedx.org/en/latest/documentors/references/quick_reference_rst.html#directives
For this PR, I made the correction so it should be all set.
@jesgreco 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Adding 6 images to better describe the process of translating strings within Transifex.