Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fc-0068: add see also tables1 #698

Merged
merged 35 commits into from
Jan 14, 2025
Merged

fc-0068: add see also tables1 #698

merged 35 commits into from
Jan 14, 2025

Conversation

jesgreco
Copy link
Contributor

add see also table to add_annotation.rst

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 19, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 19, 2024 •
edited
Loading

Thanks for the pull request, @jesgreco!

This repository is currently maintained by @openedx/docs-openedx-org-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@jesgreco jesgreco requested review from sarina and jswope00 December 19, 2024 17:53
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Dec 19, 2024
jesica-greco-zocdoc and others added 23 commits December 20, 2024 12:01
@jesica-greco-zocdoc
fixing see also table error
ca3124a
@jesica-greco-zocdoc
Create schedule_course.rst
bed9238
@jesica-greco-zocdoc
adjusting links for add_annotation.rst
99171aa
@jesica-greco-zocdoc
Update add_annotation.rst
6e8cdfe
@jesica-greco-zocdoc
fixing links see also tables
fc889c0
@jesica-greco-zocdoc
fixing links see also tables
64b74c4
@jesgreco
Delete source/educators/how-tos/schedule_course.rst
d1b1be9
@jesica-greco-zocdoc
adjusting links
197939b
@jesica-greco-zocdoc
adjusting links
43e203e
@jesica-greco-zocdoc
Merge branch 'jesgreco/seealsotables1' of https://github.com/aulasneo…
d3a9078 
…/docs.openedx.org into jesgreco/seealsotables1
@jesica-greco-zocdoc
adjusting links_deleting stash
57fc43b
@jesica-greco-zocdoc
fixing error see also table
97aca1d
@jesica-greco-zocdoc
fixing space error
17b15ea
@jesica-greco-zocdoc
see also table for add_calculation.rst
839d5f6
@jesica-greco-zocdoc
adding see also table for export_a_course_tag.rst
b1509ef
@jesica-greco-zocdoc
adding see also table for add_delete_course_tags.rst
235c6ae
@jesica-greco-zocdoc
adding see also table for create_flat_taxonomy_by_uploading_CSV.rst
0cd62c6
@jesica-greco-zocdoc
adding see also tables for 3 files
88eac46 
build_a_course.rst
build_taxonomy_using_template.rst
connect_teams_content_group.rst
@jesica-greco-zocdoc
adding see also tables for 3 files
3e7f5a7 
using_lti.rst
use_section_independently_of_ course_outline.rst
set_subsection_problem_date.rst
@jesica-greco-zocdoc
fixing errors
a1133ce
@jesica-greco-zocdoc
fixing error for use_section_independently_of_course_outline.rst
e729573
@jesica-greco-zocdoc
fixing error for use_section_independently_of_course_outline.rst
afd9e4e
@jesica-greco-zocdoc
fixing error for use_section_independently_of_course_outline.rst
eaae955
@jesgreco
Copy link
Contributor Author

@sarina @jswope00 this PR is ready to be merged.

sarina
sarina requested changes Jan 3, 2025
View reviewed changes
source/educators/how-tos/connect_teams_content_groups.rst
.. image:: /_images/educator_how_tos/teams_within_groups.png

:class: dropdown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the .. seealso, are you being sure to view the rendered documents to make sure they look correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

sarina
sarina reviewed Jan 8, 2025
View reviewed changes
source/educators/how-tos/connect_teams_content_groups.rst
.. image:: /_images/educator_how_tos/teams_within_groups.png

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesgreco you need to put in the "see also" here! Please don't resolve comments until I've verified you understood my comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ;)

sarina
sarina approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesgreco this looks good but there are conflicts that need to be resolved. Once that's done, tag me for merge.

@sarina sarina merged commit ed67690 into openedx:main Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarina sarina sarina approved these changes

@jswope00 jswope00 jswope00 approved these changes

Assignees
No one assigned
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jesgreco @openedx-webhooks @jswope00 @sarina @mphilbrick211 @jesica-greco-zocdoc