Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Release Notes for Quince #441

Merged
merged 22 commits into from
Dec 12, 2023
Merged

docs: Release Notes for Quince #441

merged 22 commits into from
Dec 12, 2023

Conversation

feoh
Copy link
Contributor

@feoh feoh commented Nov 30, 2023 •
edited
Loading

@feoh
docs: Release Notes for Quince
c321e1a 
Release notes for the Quince release of OpenEdX platform.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 30, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 30, 2023 •
edited
Loading

Thanks for the pull request, @feoh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@feoh feoh self-assigned this Nov 30, 2023
@feoh feoh marked this pull request as draft November 30, 2023 21:32
@feoh feoh requested a review from pdpinch November 30, 2023 21:33
feoh added 2 commits November 30, 2023 17:01
@feoh
docs: Fix ReStructuredText syntax errors.
578b362 
Because my brain runs Markdown whether it's formally correct or not :)
@feoh
docs: Add more features I think might be relevant
e5822f1 
Went through the github changes and found more I think are
release note worthy.
@pdpinch
Copy link
Contributor

pdpinch commented Dec 5, 2023

@feoh for the convenience of your reviewers, please add a link to the read the docs build for your PR: https://docsopenedxorg--441.org.readthedocs.build/en/441/community/release_notes/quince.html (I found that URL by clicking the "details" link next to the docs/readthedocs.org:docsopenedxorg test.

pdpinch
pdpinch requested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@pdpinch pdpinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bones are good, but let's flesh it out more.

source/community/release_notes/quince.rst Outdated Show resolved Hide resolved
source/community/release_notes/quince.rst Outdated Show resolved Hide resolved
source/community/release_notes/quince.rst Outdated Show resolved Hide resolved
source/community/release_notes/quince.rst Outdated Show resolved Hide resolved
source/community/release_notes/quince.rst Show resolved Hide resolved
source/community/release_notes/quince.rst Show resolved Hide resolved
source/community/release_notes/quince.rst Outdated Show resolved Hide resolved
source/community/release_notes/quince.rst Outdated Show resolved Hide resolved
@feoh feoh marked this pull request as ready for review December 5, 2023 22:48
pdpinch
pdpinch requested changes Dec 6, 2023
View reviewed changes
source/community/release_notes/quince.rst Outdated Show resolved Hide resolved
source/community/release_notes/quince.rst Outdated Show resolved Hide resolved
source/community/release_notes/quince.rst Outdated Show resolved Hide resolved
source/community/release_notes/quince.rst Outdated Show resolved Hide resolved
source/community/release_notes/quince.rst Outdated Show resolved Hide resolved
source/community/release_notes/quince.rst Show resolved Hide resolved
arbrandes
arbrandes requested changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for your work on this.

I would like to see a couple of late-breaking additions, though.

source/community/release_notes/quince.rst Show resolved Hide resolved
@feoh feoh requested a review from arbrandes December 11, 2023 17:48
pdpinch
pdpinch requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@pdpinch pdpinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a known issue for "Search isn't available in the new Learner Dashboard" and link to openedx/wg-build-test-release#321

@pdpinch
Copy link
Contributor

pdpinch commented Dec 11, 2023

@sarina @jmakowski1123 are either of you interested in reviewing this? There's not much time before we need to merge this, but we can always make updates.

@jmakowski1123
Copy link
Contributor

Two related features that are missing are the 1) New Files page, which includes the page as a new MFE with new functionality, and 2) improvements to the video upload flow. I had touched base with @arbrandes on whether the new Files MFE was included, not sure what the outcome of that was?

Files release notes: https://docs.google.com/document/d/1tTNCJ54oodT7k38X2YIOpQlk8_gQWFOgypiijJ4jB28/edit#heading=h.tc8j7vnjjwws

Video release notes: https://openedx.atlassian.net/wiki/spaces/COMM/pages/3915120666/New+Video+Upload+Flow+Has+Been+Rolled+Out

jalondonot
jalondonot approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jalondonot jalondonot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the changes other reviewers already requested, seems good to me! thanks for the awesome work, @feoh

arbrandes
arbrandes approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@feanil feanil merged commit b41a940 into openedx:main Dec 12, 2023
2 checks passed
@openedx-webhooks
Copy link

@feoh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@feoh feoh deleted the quince_release_notes branch December 12, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisb regisb regisb left review comments

@ormsbee ormsbee ormsbee left review comments

@pdpinch pdpinch pdpinch requested changes

@jalondonot jalondonot jalondonot approved these changes

@arbrandes arbrandes arbrandes approved these changes

@mariajgrimaldi mariajgrimaldi Awaiting requested review from mariajgrimaldi

@ghassanmas ghassanmas Awaiting requested review from ghassanmas

@timmc-edx timmc-edx Awaiting requested review from timmc-edx

@awais786 awais786 Awaiting requested review from awais786

@farhan farhan Awaiting requested review from farhan

Assignees

@feoh feoh

Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quince Release Notes
9 participants
@feoh @openedx-webhooks @pdpinch @jmakowski1123 @ormsbee @regisb @arbrandes @jalondonot @feanil