-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FC-0012 - add atlas support for cookiecutter-django-app #392
feat: FC-0012 - add atlas support for cookiecutter-django-app #392
Conversation
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
ready for review @OmarIthawi @brian-smith-tcril |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shadinaif, it looks good and needs the following changes to be ready:
atlas pull
needs to be added toMakefile
openedx-atlas
pip requirement is needed.
@brian-smith-tcril @e0d would you mind enabling tests for this pull request? |
Update cookiecutter-django-app to support atlas for all new apps Refs: FC-0012 OEP-58
96662db
to
17c45df
Compare
@brian-smith-tcril another approval here for the pull request tests please. |
@shadinaif A similar note here: This PR seems to be part of FC-0012. Would you mind updating the title to reflect that? @brian-smith-tcril We've got a green build so this is ready for final review/merge. |
Title updated @itsjeyd , thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it and it works right. Thanks @shadinaif!!
@jmbowman you are listed as "Please inform" on the spreadsheet. I plan on merging this one tomorrow morning, so please let me know if you have any objections. |
feat: add atlas support for cookiecutter-django-app
Update cookiecutter-django-app to support atlas for all new apps
This PR prepares the repository to comply with openedx-translations by doing the following:
Only for
cookiecutter-django-app
:i18_tool extract
to extract transactionsHow it was tested?
cookiecutter -o testdir cookiecutter-django-app
make upgrade
make requirements
make extract_translations
: everything looks finemake validate
: no errorsReferences
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you notice any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes
For XBlocks:
conf/locale
. Therefore, we are creating a link fromconf/locale
totranslations
so Atlas can find the path without disrupting the current way of having translations locally within the XBlocks