Upgrade some dependencies that were very out of date. #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2132 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 191 191
Lines 20540 20540
Branches 1859 1859
=======================================
Hits 19516 19516
Misses 767 767
Partials 257 257
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Despite being a minor version, this version introduces a breaking change. Unhandled errors thrown in promises are now caught by the test framework and treated as errors. Jasmine Changelog: https://github.com/jasmine/jasmine/blob/main/release_notes/3.6.0.md Specific fix: jasmine/jasmine#1778 This helped uncover a hidden error in our testing with how we were instantiating views for testing. The `data` element that gets passed into a view during testing was missing the `TEXT_RESPONSE_EDITOR` key which indicates which editor to load. I think because enough of the rest of the test is stubbed out we didn't notice the error but I'm not sure about this. For now rather than ignoring the error, I've updated the spec instantiation code to have a valid value for the `TEXT_RESPONSE_EDITOR` key so that the views get created more accurately. I'm not confident that tests are doing everything they're supposed to because they're a bit difficult to follow but for now they should at least not be throwing unexpected exceptions while instantiating the views. We also upgrade a few other build packages to the point where they can't be updated further without spending more time debugging test failures.
feanil
force-pushed
the
feanil/upgrade_try3
branch
from
89349fc to
54278d2
Compare
feanil
changed the title
nsprenkle
reviewed
Dec 5, 2023
| @@ -139,7 +140,8 @@ describe("OpenAssessment.PeerView", function() { | |||
| expect(view.continueAssessmentEnabled()).toBe(true); | |||
| }); | |||
|
|
|||
| it("warns of unsubmitted assessments", function() { | |||
| // Turing this off for now because it's flaky | |||
| xit("warns of unsubmitted assessments", function() { | |||
There was a problem hiding this comment.
Any idea of why this is flaky?
There was a problem hiding this comment.
Unfortunately, I didn't investigate that since it was not what I was focusing on.
nsprenkle
approved these changes
Dec 5, 2023
leangseu-edx
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempting to upgrade frontend-build I ran into a bunch of issues but these are some of the packages I managed to upgrade while fixing some tests that were failing but not getting caught.