fix: serialization of unfinished, unscored peer assignments #2142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - Fixes issue serializing grades for unfinished, unscored peer assignments.
What changed?
We were running into the issue below when trying to get grade data for peers in new ORA experience:
It was determined that this came from serializing unscored peer workflow items that didn't have an associated assessment (unfinished assessment) based on how we are doing that lookup. Added a
null
check to the filter to remove these from the resopnse.Developer Checklist
Testing Instructions
See UAT tests.
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora