Skip to content

Commit

Permalink
feat! Dropping Sass support from builtin Sequence block (#35770)
Browse files Browse the repository at this point in the history
feat!: Dropping Sass support from builtin sequence block

Co-authored by @ttqureshi
  • Loading branch information
ttqureshi authored Nov 5, 2024
1 parent b7d08fb commit 01985e0
Show file tree
Hide file tree
Showing 4 changed files with 367 additions and 346 deletions.
3 changes: 0 additions & 3 deletions xmodule/assets/SequenceBlockDisplay.scss

This file was deleted.

340 changes: 0 additions & 340 deletions xmodule/assets/sequence/_display.scss

This file was deleted.

6 changes: 3 additions & 3 deletions xmodule/seq_block.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from xblock.fields import Boolean, Integer, List, Scope, String

from edx_toggles.toggles import WaffleFlag, SettingDictToggle
from xmodule.util.builtin_assets import add_webpack_js_to_fragment, add_sass_to_fragment
from xmodule.util.builtin_assets import add_webpack_js_to_fragment, add_css_to_fragment
from xmodule.x_module import (
ResourceTemplates,
shim_xmodule_js,
Expand Down Expand Up @@ -459,7 +459,7 @@ def student_view(self, context):
banner_text, special_html = special_html_view
if special_html and not masquerading_as_specific_student:
fragment = Fragment(special_html)
add_sass_to_fragment(fragment, 'SequenceBlockDisplay.scss')
add_css_to_fragment(fragment, 'SequenceBlockDisplay.css')
add_webpack_js_to_fragment(fragment, 'SequenceBlockDisplay')
shim_xmodule_js(fragment, 'Sequence')
return fragment
Expand Down Expand Up @@ -601,7 +601,7 @@ def _student_or_public_view(self, context, prereq_met, prereq_meta_info, banner_
self._capture_full_seq_item_metrics(children)
self._capture_current_unit_metrics(children)

add_sass_to_fragment(fragment, 'SequenceBlockDisplay.scss')
add_css_to_fragment(fragment, 'SequenceBlockDisplay.css')
add_webpack_js_to_fragment(fragment, 'SequenceBlockDisplay')
shim_xmodule_js(fragment, 'Sequence')
return fragment
Expand Down
Loading

0 comments on commit 01985e0

Please sign in to comment.