Skip to content

Commit

Permalink
change notification app name (#34672)
Browse files Browse the repository at this point in the history
  • Loading branch information
AhtishamShahid authored Apr 30, 2024
1 parent d022766 commit 2bd73ca
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions openedx/core/djangoapps/notifications/base_notification.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
'filters': [FILTER_AUDIT_EXPIRED_USERS_WITH_NO_ROLE]
},
'ora_staff_notification': {
'notification_app': 'ora',
'notification_app': 'grading',
'name': 'ora_staff_notification',
'is_core': False,
'info': '',
Expand Down Expand Up @@ -227,9 +227,9 @@
'core_email_cadence': EmailCadence.DAILY,
'non_editable': []
},
'ora': {
'grading': {
'enabled': True,
'core_info': _('Notifications for Open response submissions.'),
'core_info': _('Notifications for submission grading.'),
'core_web': True,
'core_email': True,
'core_push': True,
Expand Down
12 changes: 6 additions & 6 deletions openedx/core/djangoapps/notifications/tests/test_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def _expected_api_response(self, course=None):
},
'non_editable': {}
},
'ora': {
'grading': {
'enabled': True,
'core_notification_types': [],
'notification_types': {
Expand All @@ -314,7 +314,7 @@ def _expected_api_response(self, course=None):
'email': True,
'push': True,
'email_cadence': 'Daily',
'info': 'Notifications for Open response submissions.'
'info': 'Notifications for submission grading.'
}
},
'non_editable': {}
Expand Down Expand Up @@ -601,7 +601,7 @@ def _expected_api_response(self, course=None):
},
'non_editable': {}
},
'ora': {
'grading': {
'enabled': True,
'core_notification_types': [],
'notification_types': {
Expand All @@ -617,7 +617,7 @@ def _expected_api_response(self, course=None):
'email': True,
'push': True,
'email_cadence': 'Daily',
'info': 'Notifications for Open response submissions.'
'info': 'Notifications for submission grading.'
}
},
'non_editable': {}
Expand Down Expand Up @@ -926,7 +926,7 @@ def test_get_unseen_notifications_count_with_show_notifications_tray(self, show_
self.assertEqual(response.status_code, 200)
self.assertEqual(response.data['count'], 4)
self.assertEqual(response.data['count_by_app_name'], {
'App Name 1': 2, 'App Name 2': 1, 'App Name 3': 1, 'discussion': 0, 'updates': 0, 'ora': 0})
'App Name 1': 2, 'App Name 2': 1, 'App Name 3': 1, 'discussion': 0, 'updates': 0, 'grading': 0})
self.assertEqual(response.data['show_notifications_tray'], show_notifications_tray_enabled)

def test_get_unseen_notifications_count_for_unauthenticated_user(self):
Expand All @@ -947,7 +947,7 @@ def test_get_unseen_notifications_count_for_user_with_no_notifications(self):

self.assertEqual(response.status_code, 200)
self.assertEqual(response.data['count'], 0)
self.assertEqual(response.data['count_by_app_name'], {'discussion': 0, 'updates': 0, 'ora': 0})
self.assertEqual(response.data['count_by_app_name'], {'discussion': 0, 'updates': 0, 'grading': 0})

def test_get_expiry_days_in_count_view(self):
"""
Expand Down

0 comments on commit 2bd73ca

Please sign in to comment.