Skip to content

Commit

Permalink
Merge pull request #34014 from openedx/hot-fix-hide-feedback-widget-w…
Browse files Browse the repository at this point in the history
…hen-no-video-id

fix: prevent transcript feedback widget from appearing when there is no video_id
  • Loading branch information
Guilleves authored Jan 8, 2024
2 parents 9cd1d7c + 9979ea2 commit 2dee428
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lms/templates/video.html
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ <h4 class="hd hd-5">${_('Video')}</h4>
<div class="btn-link close-btn float-right">
<span style="color: black" class="icon fa fa-close" />
</div>

<br />
% for sharing_site_info in sharing_sites_info:
<a
Expand Down Expand Up @@ -153,7 +153,7 @@ <h4 class="hd hd-5">${_('Handouts')}</h4>
% endif
</div>
% endif
% if transcript_feedback_enabled:
% if transcript_feedback_enabled and video_id:
<div class="wrapper-transcript-feedback" data-video-id='${video_id}' data-user-id='${user_id}'>
<h4 class="hd hd-5">${_('How is the transcript quality ?')}</h4>
<div class="transcript-feedback-buttons">
Expand Down

0 comments on commit 2dee428

Please sign in to comment.