Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xblock-vectordraw to requirements. #10932

Merged
merged 1 commit into from
Dec 10, 2015

Conversation

itsjeyd
Copy link
Contributor

@itsjeyd itsjeyd commented Dec 10, 2015

Replaces #10515.

The Vector Drawing XBlock was reviewed in this PR: open-craft/xblock-vectordraw#1.

@openedx-webhooks
Copy link

Thanks for the pull request, @itsjeyd! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?number=10932&repo=edx%2Fedx-platform

@sarina
Copy link
Contributor

sarina commented Dec 10, 2015

@itsjeyd can you link to the review PR for the xblock itself, so that context is present here?

@itsjeyd
Copy link
Contributor Author

itsjeyd commented Dec 10, 2015

@sarina Sure thing, added a note to the description.

@nedbat
Copy link
Contributor

nedbat commented Dec 10, 2015

How are we deciding between github.txt and edx-private.txt for these XBlocks?

@sarina
Copy link
Contributor

sarina commented Dec 10, 2015

OK, contingent on tests passing and the promise that your team will follow up on final a11y work next week with Mark (cc @antoviaque FYI), 👍

Go ahead and merge when it's ready.

@sarina
Copy link
Contributor

sarina commented Dec 10, 2015

Oh, right. @itsjeyd this should go in edx-private; it's not an XBlock we want to force on every Open edX installation.

@itsjeyd
Copy link
Contributor Author

itsjeyd commented Dec 10, 2015

@sarina @nedbat OK, I'll fix that. Thanks!

@itsjeyd itsjeyd force-pushed the tim/add-xblock-vectordraw branch from 8ac4aef to 0ea255b Compare December 10, 2015 16:13
@itsjeyd
Copy link
Contributor Author

itsjeyd commented Dec 10, 2015

@sarina OK, done -- added at the end of the file.

itsjeyd added a commit that referenced this pull request Dec 10, 2015
@itsjeyd itsjeyd merged commit 7253e3c into openedx:master Dec 10, 2015
@itsjeyd
Copy link
Contributor Author

itsjeyd commented Dec 10, 2015

@sarina Following up on the question above about github.txt vs edx-private.txt, what are the criteria for including an XBlock in Open edX? :)

@sarina
Copy link
Contributor

sarina commented Dec 10, 2015

XBlocks we think are so core to the edX experience we want everyone to have
them. For example if Capa moved to an XBlock, it would be a default.

On Thu, Dec 10, 2015 at 12:32 PM, Tim Krones [email protected]
wrote:

@sarina https://github.com/sarina Following up on the question above
about github.txt vs edx-private.txt, what are the criteria for
including an XBlock in Open edX? :)


Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/10932#issuecomment-163696695.

@antoviaque
Copy link
Contributor

@sarina Thanks for letting this being merged now btw - we'll definitely keep both XBlocks in our next sprint scope next week, to ensure we keep time to address any additional comments from Mark.

CC @bradenmacdonald

@openedx-webhooks
Copy link

Thanks for the pull request, @itsjeyd! I've created OSPR-1052 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U needs triage labels Dec 31, 2015
@bradenmacdonald bradenmacdonald deleted the tim/add-xblock-vectordraw branch May 18, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants