-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xblock-vectordraw to requirements. #10932
Conversation
Thanks for the pull request, @itsjeyd! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request. To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?number=10932&repo=edx%2Fedx-platform |
@itsjeyd can you link to the review PR for the xblock itself, so that context is present here? |
@sarina Sure thing, added a note to the description. |
How are we deciding between github.txt and edx-private.txt for these XBlocks? |
OK, contingent on tests passing and the promise that your team will follow up on final a11y work next week with Mark (cc @antoviaque FYI), 👍 Go ahead and merge when it's ready. |
Oh, right. @itsjeyd this should go in edx-private; it's not an XBlock we want to force on every Open edX installation. |
8ac4aef
to
0ea255b
Compare
@sarina OK, done -- added at the end of the file. |
Add xblock-vectordraw to requirements.
@sarina Following up on the question above about github.txt vs edx-private.txt, what are the criteria for including an XBlock in Open edX? :) |
XBlocks we think are so core to the edX experience we want everyone to have On Thu, Dec 10, 2015 at 12:32 PM, Tim Krones [email protected]
|
@sarina Thanks for letting this being merged now btw - we'll definitely keep both XBlocks in our next sprint scope next week, to ensure we keep time to address any additional comments from Mark. |
Thanks for the pull request, @itsjeyd! I've created OSPR-1052 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
Replaces #10515.
The Vector Drawing XBlock was reviewed in this PR: open-craft/xblock-vectordraw#1.