Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to Quince: upgrading ipware #33889

Conversation

magajh
Copy link
Contributor

@magajh magajh commented Dec 6, 2023

Description

This is a backport of #33804 to Quince.

This PR updates the usage of ipware to align with its recent division into django-ipware and python-ipware.
https://pypi.org/project/django-ipware/#:~:text=,6.0.0
https://github.com/un33k/python-ipware

Deadline

Preferably before Quince release.

Other information

This PR is a prerequisite for #33764 to ensure that the tests run correctly

awais786 and others added 3 commits December 6, 2023 12:22
Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`

Co-authored-by: awais786 <[email protected]>
@openedx-webhooks
Copy link

Thanks for the pull request, @magajh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 6, 2023
@magajh magajh force-pushed the magajh/upgrading-ipware branch from 2651f47 to 53c44da Compare December 6, 2023 19:21
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Dec 7, 2023
@mariajgrimaldi
Copy link
Member

Hi there, @magajh. Is this still a requirement? I see the Django security update PR was merged before this PR.

@magajh
Copy link
Contributor Author

magajh commented Jan 28, 2024

Hey, @mariajgrimaldi. I don't believe this change is a requirement anymore since it isn't currently blocking any issues. Could you confirm if there are any other issues identified in the BTR that might benefit from this backport? If not, then I think we can close this PR.

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Feb 2, 2024

The advantages of upgrading ipware are unclear to me, so I'm not sure we should commit to the major version jump. Either way, I'll ask internally and let you know. Thanks!

@cmltaWt0
Copy link
Contributor

cmltaWt0 commented Feb 5, 2024

I don’t feel comfortable introducing a major upgrade in the middle of the release cycle unless it’s absolutely necessary.

@mariajgrimaldi
Copy link
Member

I'll be closing this PR, given the previous comments. Thank you folks!

@openedx-webhooks
Copy link

@magajh Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants