-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport to Quince: upgrading ipware #33889
Backport to Quince: upgrading ipware #33889
Conversation
Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master` Co-authored-by: awais786 <[email protected]>
Thanks for the pull request, @magajh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
2651f47
to
53c44da
Compare
Hi there, @magajh. Is this still a requirement? I see the Django security update PR was merged before this PR. |
Hey, @mariajgrimaldi. I don't believe this change is a requirement anymore since it isn't currently blocking any issues. Could you confirm if there are any other issues identified in the BTR that might benefit from this backport? If not, then I think we can close this PR. |
The advantages of upgrading ipware are unclear to me, so I'm not sure we should commit to the major version jump. Either way, I'll ask internally and let you know. Thanks! |
I don’t feel comfortable introducing a major upgrade in the middle of the release cycle unless it’s absolutely necessary. |
I'll be closing this PR, given the previous comments. Thank you folks! |
@magajh Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This is a backport of #33804 to Quince.
This PR updates the usage of ipware to align with its recent division into django-ipware and python-ipware.
https://pypi.org/project/django-ipware/#:~:text=,6.0.0
https://github.com/un33k/python-ipware
Deadline
Preferably before Quince release.
Other information
This PR is a prerequisite for #33764 to ensure that the tests run correctly