-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixing the prompt view cancel button style for color and cursor shape #33895
fix: fixing the prompt view cancel button style for color and cursor shape #33895
Conversation
Thanks for the pull request, @bogdan3d! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
3839661
to
a1764cb
Compare
a1764cb
to
8f94df0
Compare
bc64282
to
b50b357
Compare
…lor-and-cursor-shape
@mariajgrimaldi thanks for running the checks on this! Who should be assigned as a reviewer? |
@bogdan3d: I'll do it! Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally, and it worked as expected. Thank you so much!
@bogdan3d 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Hi @bogdan3d! Could you help us backporting this PR to quince? Let me know. Thanks! |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
@mariajgrimaldi of course! Pull request for you here: #34209 (The force push was to update the commit message - I didn't know that there was a 100 character limit and that was causing checks to fail. This has been fixed.) |
Description
This fixes the Prompt View
Cancel
option to have the proper style for color and cursor shape.This was a style that missed when the element for
action-secondary
was updated frombutton
toa
here:3eb4e0c#diff-0cc73d38a75fb2b57e41c9660dec6dad6fd079d8b8322b19d369e5baaadc3c52L33-R33
The change follows the style that was implemented for other
action-secondary
elements:3eb4e0c#diff-a21e3eaa1e33ca8a10c73f3a53dca3d58ee463ddfe1eb94a9574e8762396c4ceR586-R594
Supporting information
Testing instructions
tutor dev do createuser --staff --superuser admin [email protected]
Content
in the top menu, then onUpdates
.+ New update
in the top right.Delete
button for the update to see the confirmation prompt.Cancel
button to reproduce the problem described in the issue ([Cursor shape on hovering] <TC_AUTHOR_81>: <hovering over "Cancel" button, cursor does not changes to hand icon> wg-build-test-release#322).Delete
button for the update to see the confirmation prompt.Deadline
N/A
Other information
This is a video of the functionality from the
palm
release to show the expected style and behavior:This is a video reproducing the issue:
This is a video of the fix:
The white color for this was chosen because it was approved for a similar element here (note the orange button, orange header line, and white cancel link):
#33197 (comment)