Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing the prompt view cancel button style for color and cursor shape #33895

Conversation

bogdan3d
Copy link
Contributor

@bogdan3d bogdan3d commented Dec 7, 2023

Description

This fixes the Prompt View Cancel option to have the proper style for color and cursor shape.

This was a style that missed when the element for action-secondary was updated from button to a here:
3eb4e0c#diff-0cc73d38a75fb2b57e41c9660dec6dad6fd079d8b8322b19d369e5baaadc3c52L33-R33

The change follows the style that was implemented for other action-secondary elements:
3eb4e0c#diff-a21e3eaa1e33ca8a10c73f3a53dca3d58ee463ddfe1eb94a9574e8762396c4ceR586-R594

Supporting information

Testing instructions

  1. Set up tutor nightly (steps can be found here: https://docs.tutor.edly.io/tutorials/nightly.html).
  2. Create an admin user: tutor dev do createuser --staff --superuser admin [email protected]
  3. Go to studio: http://studio.local.overhang.io:8001/
  4. Create a course.
  5. Click into the course.
  6. Go to Course Updates by clicking on Content in the top menu, then on Updates.
  7. Create an update by clicking on + New update in the top right.
  8. Click on the Delete button for the update to see the confirmation prompt.
  9. Observe the color and hover the Cancel button to reproduce the problem described in the issue ([Cursor shape on hovering] <TC_AUTHOR_81>: <hovering over "Cancel" button, cursor does not changes to hand icon> wg-build-test-release#322).
  10. Update to use this branch by mounting a clone of the repository (steps can be found here: https://docs.tutor.edly.io/dev.html)
  11. Rebuild.
  12. Refresh the Course Updates page.
  13. Click on the Delete button for the update to see the confirmation prompt.
  14. Confirm that the color and cursor for the delete link are fixed.

Deadline

N/A

Other information

This is a video of the functionality from the palm release to show the expected style and behavior:
testing_bug_322_incorrect_cursor_icon_in_palm_release

This is a video reproducing the issue:
testing_bug_322_reproduce

This is a video of the fix:
testing_bug_322_fix

The white color for this was chosen because it was approved for a similar element here (note the orange button, orange header line, and white cancel link):
#33197 (comment)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 7, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @bogdan3d! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bogdan3d bogdan3d force-pushed the fix-prompt-view-cancel-button-style-for-color-and-cursor-shape branch from 3839661 to a1764cb Compare December 8, 2023 05:26
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 8, 2023
@bogdan3d bogdan3d force-pushed the fix-prompt-view-cancel-button-style-for-color-and-cursor-shape branch from a1764cb to 8f94df0 Compare December 12, 2023 17:45
@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 14, 2023
@bogdan3d bogdan3d force-pushed the fix-prompt-view-cancel-button-style-for-color-and-cursor-shape branch from bc64282 to b50b357 Compare December 15, 2023 16:32
@bogdan3d
Copy link
Contributor Author

@mariajgrimaldi thanks for running the checks on this! Who should be assigned as a reviewer?

@mariajgrimaldi
Copy link
Member

@bogdan3d: I'll do it! Thanks

@mariajgrimaldi mariajgrimaldi self-requested a review February 2, 2024 12:12
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally, and it worked as expected. Thank you so much!

@mariajgrimaldi mariajgrimaldi merged commit 09d4835 into openedx:master Feb 2, 2024
64 checks passed
@openedx-webhooks
Copy link

@bogdan3d 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@mariajgrimaldi
Copy link
Member

Hi @bogdan3d! Could you help us backporting this PR to quince? Let me know. Thanks!

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@bogdan3d
Copy link
Contributor Author

bogdan3d commented Feb 8, 2024

Hi @bogdan3d! Could you help us backporting this PR to quince? Let me know. Thanks!

@mariajgrimaldi of course! Pull request for you here: #34209

(The force push was to update the commit message - I didn't know that there was a 100 character limit and that was causing checks to fail. This has been fixed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
5 participants