-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0044] textbooks API DRF #34388
feat: [FC-0044] textbooks API DRF #34388
Conversation
Thanks for the pull request, @ruzniaievdm! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
1ac442b
to
e15d923
Compare
Serializer for representing course's textbooks. | ||
""" | ||
|
||
textbooks = serializers.ListField() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
textbooks = serializers.ListField() | |
textbooks = serializers.ListField( | |
child=CourseTextbookItemSerializer() | |
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, added, thanks
7e02672
to
ab40c07
Compare
ab40c07
to
08a987d
Compare
@ruzniaievdm 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Settings
Description
This PR addresses a need in the development of the Course Textbooks Page feature within the frontend-app-course-authoring repository. The core objective is the implement of a DRF endpoint designed to render and deliver textbooks data for course.
Learn about textbooks:
Textbooks Pages:
http://localhost:18010/textbooks/{location}
.http://localhost:2001/course/{location}/pages-and-resources/textbooks
.Testing API instructions:
make dev.up.lms+cms
and make checkout on this branch.http://localhost:18010/api-docs
./api/contentstore/v1/textbooks/{location}
.Testing MFE instructions:
make dev.up.lms+cms+frontend-app-course-authoring
and make checkout on this branch.contentstore.new_studio_mfe.use_new_textbooks_page
on thehttp://localhost:18010/admin/waffle/flag/
http://localhost:2001/course/{location}/pages-and-resources/textbooks
.Related PR's:
Textbooks issue
openedx/platform-roadmap#319