Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly handles the enabling of submit button on reset #35118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: correctly handles the enabling of submit button on reset #35118

wants to merge 1 commit into from
+50 −7

Conversation

imasdekar
Copy link

@imasdekar imasdekar commented Jul 14, 2024 •
edited by mariajgrimaldi
Loading

  • disables the submit button on the click of reset button except for the cases when there is a gentle alert notification.

closes openedx/frontend-app-learning#1406
closes openedx/wg-build-test-release#362

Signed-off by: Ishan Masdekar [email protected]

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 14, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 14, 2024 •
edited
Loading

Thanks for the pull request, @imasdekar!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 16, 2024
@imasdekar imasdekar force-pushed the submit_button_reset branch from 614ef63 to bf4fce0 Compare July 17, 2024 07:17
@imasdekar imasdekar mentioned this pull request Jul 17, 2024
Closed
@imasdekar imasdekar force-pushed the submit_button_reset branch 3 times, most recently from cd2e075 to 1f4e7e8 Compare July 18, 2024 11:58
@e0d
Copy link
Contributor

e0d commented Jul 24, 2024

Your branch is behind the base. I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run.

@mphilbrick211 mphilbrick211 added needs reviewer assigned PR needs to be (re-)assigned a new reviewer and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Jul 24, 2024
@imasdekar imasdekar force-pushed the submit_button_reset branch from 6de8011 to b37ca7c Compare July 31, 2024 06:29
@imasdekar
Copy link
Author

@mariajgrimaldi this is resolving the openedx/frontend-app-learning#1406
can you please review this?

@imasdekar imasdekar force-pushed the submit_button_reset branch from b37ca7c to a7d9c3a Compare August 2, 2024 07:18
@imasdekar
Copy link
Author

@e0d @mphilbrick211 can you please review this or ask an appropriate person to review it?

@mphilbrick211
Copy link

Hi @imasdekar! Thanks for your patience. We have this out to the community for review.

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Sep 23, 2024 •
edited
Loading

Hi @imasdekar, thanks again for the contribution! However, I can't see how this solution solves openedx/frontend-app-learning#1406 since the changes introduced by this PR impact only the learning legacy view, which is different from the Learning MFE https://github.com/openedx/frontend-app-learning. Am I missing something? Let me know!

@imasdekar
Copy link
Author

@mariajgrimaldi As far as I understand the problem block is rendered in an iframe in frontend-app-learning so I implemented the fix here. Let me know if that is not the case.

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Sep 30, 2024 •
edited
Loading

@imasdekar: you're absolutely right. I'm sorry, I got it all mixed up :)

I'll be reviewing this soon, thank you again!

@mariajgrimaldi mariajgrimaldi self-requested a review September 30, 2024 15:44
@mariajgrimaldi mariajgrimaldi linked an issue Oct 28, 2024 that may be closed by this pull request
[Test failure] <TC_AUTHOR_50>: <Reset option is not working properly for submit button in common problem components> openedx/wg-build-test-release#362
Open
@imasdekar
Copy link
Author

@mariajgrimaldi i got a notification about some comment from your side but I cannot see it here.

@mphilbrick211
Copy link

@imasdekar @mariajgrimaldi - flagging some extra checks have popped up, and putting this back on the radar.

@mphilbrick211 mphilbrick211 removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Dec 10, 2024
@imasdekar
fix: correctly handles the enabling of submit button on reset
c305aba 
- disables the submit button on the click of reset button except for the
cases when there is a gentle alert notification.
- adds an argument to the disableAllButtonsWhileRunning function to
identify the caller was reset/submit/save.

closes openedx/frontend-app-learning#1406

Signed-off by: Ishan Masdekar <[email protected]>
@imasdekar
Copy link
Author

@mphilbrick211 I have rebased the changes. Can you please get the checks to rerun and also get the code reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariajgrimaldi mariajgrimaldi Awaiting requested review from mariajgrimaldi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Ready for Review
Milestone
No milestone
5 participants
@imasdekar @openedx-webhooks @e0d @mphilbrick211 @mariajgrimaldi