-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: upgrade get_issued_certificates to DRF ( 24 ) #35534
Conversation
common method for both post and get. This method will return all issued certificates. | ||
""" | ||
course_key = CourseKey.from_string(course_id) | ||
csv_required = request.GET.get('csv', 'false') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be available if we're calling with the POST method? Also, it seems like the original implementation does not provide POST
why are we adding POST
support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feanil, the previous code did not restrict any HTTP methods, so both GET and POST were functioning when tested via Postman. However, only the POST method is implemented on the front-end.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Issue
Testing step via postman
expected result
You can pass the ?csv=false or ?csv=true to get the csv file.
Test via dashboard.
Enable waffle flag =
instructor.enable_data_download_v2
This works with POST and GET both.