-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop Python 3.8 & Add Support for Python 3.12 #35585
Conversation
Thanks for the pull request, @merelcht! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Signed-off-by: Merel Theisen <[email protected]>
@irtazaakram I've had a stab at solving #35457, but I need some help getting the tests running. The CI builds need to be approved. I had some trouble running the tests locally. Do you have any guidance on how to set them up and run locally? |
@merelcht Thanks for taking a crack at #35457! To get the tests running locally, you'll need to install edx-platform via Tutor. You can find the setup instructions here: Tutor Development Guide. Once you're set up, you can follow this guide for running the tests locally: Running edx-platform Unit Tests. If you're just getting started, I recommend beginning with the packages listed here: Python 3.12 Support Tracking, since the edx-platform depends on most, if not all, of them being compatible with Python 3.12 first. |
I'm closing this because I'm having trouble getting everything installed properly. I don't know when I'll have time again to investigate what's going on. |
Description
Follow and complete all of the following steps for the issue to be marked as done.
Supporting information
Addresses #35457
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.