Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ADR for Fixing Quality and JS Checks #35741

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented Oct 29, 2024

This is a record of the various existing CI issues we faced and the trade-offs we made to move forward while replacing the Paver CI commands as part of:

@kdmccormick kdmccormick force-pushed the kdmccormick/quality-check-adr branch from 69bb84b to e44b8de Compare December 18, 2024 16:34
@kdmccormick kdmccormick force-pushed the kdmccormick/quality-check-adr branch from e44b8de to 3bcbfcf Compare December 18, 2024 16:37
@kdmccormick kdmccormick requested a review from feanil December 18, 2024 16:39
@kdmccormick kdmccormick mentioned this pull request Dec 18, 2024
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo suggestion otherwise looks good.

docs/decisions/0021-fixing-quality-and-js-checks.rst Outdated Show resolved Hide resolved
Co-authored-by: Feanil Patel <[email protected]>
@kdmccormick kdmccormick enabled auto-merge (squash) December 18, 2024 18:41
@kdmccormick kdmccormick merged commit 5425063 into openedx:master Dec 18, 2024
48 checks passed
@kdmccormick kdmccormick deleted the kdmccormick/quality-check-adr branch December 18, 2024 19:09
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants