-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2u/course optimizer #35887
base: master
Are you sure you want to change the base?
2u/course optimizer #35887
Conversation
dcf94db
to
e9fb603
Compare
@bszabo I updated a lot of the organization in tasks.py. I agree with you on the iffy code practices (using max / min / integer for status), but this is currently how |
Thanks for the editorial changes, Ray. I'm stepping away from this review with the expectation that Jesper will give it a lookover from a functional perspective. If it's possible to attend to the funky status definition before moving on to new things, I would strongly recommend that, even if it ends up being in a different PR. |
If you take a step back, and look at this search for broken links as a first installment towards course optimization, you can see that course optimization will entail a sequence of activities being carried out, with each intended to potentially improvew a course. Viewed that way, the natural questions to ask will be "which activity is currently being worked on?" and "what is the status for activity X?". For the latter question the natural answers will be not started, in progress, succeeded, or failed with error message Y. It seems to me that it would make sense to organize even this first installment somewhat in those lines. The solution you borrowed from import/export is conflating concepts in a way I don't think is good. |
* feat: TNL-11812 new tests * feat: TNL-11812 remove skipped tests and TODOs --------- Co-authored-by: Bernard Szabo <[email protected]>
4c72d45
to
8a585e9
Compare
Description
This PR creates the backend for Course Optimizer Link Checker, which will scan through a published course and check for broken links. This functionality imitates what is currently in place for export. 2 apis are created here:
link_check
POST[block_id, broken_link]
link_check_status
GETlink_check
if process is successful.Technical considerations:
Supporting information
https://2u-internal.atlassian.net/browse/TNL-11782
Testing instructions with frontend PR
frontend-app-authoring
: Feat course optimizer page frontend-app-authoring#1533devstack
, runmake dev.up.large-and-slow
.frontend-app-authoring
, runnpm start
.contentstore.enable_course_optimizer
.Testing instructions without frontend PR
The following example is for demo course
course-v1:edX+DemoX+Demo_Course
.export
withlink_check
.http://localhost:18010/link_check_status/course-v1:edX+DemoX+Demo_Course
in your browser. You should see the results of the link check scan.Other information
contentstore.enable_course_optimizer
frontend-app-authoring
: Feat course optimizer page frontend-app-authoring#1533