Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render library v2 assets with whitespace #35974

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DanielVZ96
Copy link
Contributor

@DanielVZ96 DanielVZ96 commented Dec 5, 2024

Description

Assets that contain whitespace fail to be rendered when uploaded to library v2.

Supporting information

Testing instructions

(Make sure you are running the latest frontend-app-authoring changes, and if it still doesn't work try running provisioning)

  1. create a text xblock
  2. upload any image that contains spaces in their name (eg."hi there.png")
  3. assert that once you save, the image gets rendered correctly

Deadline

ASAP

Other information

Extracted from: #35910
Private-Ref

@openedx-webhooks
Copy link

openedx-webhooks commented Dec 5, 2024

Thanks for the pull request, @DanielVZ96!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@DanielVZ96 DanielVZ96 force-pushed the dvz/fix-whitespace-name-assert branch from 1c2ccdb to c7c3e75 Compare December 21, 2024 02:58
@DanielVZ96 DanielVZ96 requested a review from ormsbee December 21, 2024 03:36
@DanielVZ96 DanielVZ96 marked this pull request as ready for review December 21, 2024 03:36
@DanielVZ96 DanielVZ96 requested a review from ChrisChV December 21, 2024 03:37
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will merge it on Monday 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

3 participants