Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explore Courses button doesn't follow the same style conventions of MFE header #35836 #35994

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5c85525
fix: styles conventions
jciasenza Dec 9, 2024
79ac943
Merge branch 'master' into jci/issue#35836
jciasenza Dec 9, 2024
5520a96
fix: styles conventions
jciasenza Dec 9, 2024
f779533
Merge branch 'master' into jci/issue#35836
jciasenza Dec 9, 2024
16b1c7a
Merge branch 'master' into jci/issue#35836
e0d Dec 10, 2024
016b3a6
Merge branch 'master' into jci/issue#35836
jciasenza Dec 10, 2024
9f888e4
Merge branch 'master' into jci/issue#35836
jciasenza Dec 11, 2024
c54bf3b
Merge branch 'master' into jci/issue#35836
jciasenza Dec 11, 2024
eb6694e
Merge branch 'master' into jci/issue#35836
jciasenza Dec 11, 2024
4ce6d4a
Merge branch 'master' into jci/issue#35836
jciasenza Dec 11, 2024
602a1a1
Merge branch 'master' into jci/issue#35836
jciasenza Dec 12, 2024
f37cbcf
Merge branch 'master' into jci/issue#35836
jciasenza Dec 13, 2024
6758178
Merge branch 'master' into jci/issue#35836
jciasenza Dec 13, 2024
f1e94fc
Merge branch 'master' into jci/issue#35836
jciasenza Dec 16, 2024
8201e87
Merge branch 'master' into jci/issue#35836
jciasenza Dec 17, 2024
6a68cfe
Merge branch 'master' into jci/issue#35836
jciasenza Dec 18, 2024
d073f80
Merge branch 'master' into jci/issue#35836
jciasenza Dec 19, 2024
868dd24
Merge branch 'master' into jci/issue#35836
jciasenza Dec 19, 2024
100a8b1
Merge branch 'master' into jci/issue#35836
jciasenza Dec 20, 2024
be615e4
Merge branch 'master' into jci/issue#35836
jciasenza Dec 23, 2024
8f7f08b
Merge branch 'master' into jci/issue#35836
jciasenza Dec 26, 2024
76ae4d2
Merge branch 'master' into jci/issue#35836
jciasenza Jan 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lms/templates/header/navbar-authenticated.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<div class="mobile-nav-item hidden-mobile nav-item nav-tab">
<a class="tab-nav-link discover-new-link" href="${marketing_link('COURSES')}"
aria-current="${'page' if '/courses' in request.path else 'false'}">
${_('Discover New')}
${_("Discover New")}
</a>
</div>
% endif
Expand Down
2 changes: 1 addition & 1 deletion lms/templates/header/navbar-not-authenticated.html
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
% if allows_login:
% if can_discover_courses:
<div class="mobile-nav-item hidden-mobile nav-item">
<a href="/courses">${_('Explore courses')}</a>
<a href="/courses">${_("Explore courses")}</a>
</div>
%endif
% endif
Expand Down