feat: Populate notification context with post, comment and response ids #36008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawad-khan
force-pushed
the
jawad/LEARNER-10328
branch
from
0e70ca2 to
1391010
Compare
| @@ -362,6 +373,12 @@ def send_reported_content_notification(self): | |||
| ]} | |||
| self._send_course_wide_notification("content_reported", audience_filters, context) | |||
|
|
|||
| def _populate_context_with_ids_for_mobile(self, context, additional_context=False): | |||
There was a problem hiding this comment.
Is additional_context needed as parameter here? It is not being used in the code
There was a problem hiding this comment.
Initially I added it to add more context but we don't need it now. Let me remove it.
There was a problem hiding this comment.
@muhammadadeeltajamul I have removed extra param.
muhammadadeeltajamul
approved these changes
Dec 20, 2024
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change will populate notification context with post, comment and response ids. In mobile we need these ids to load relevant screen for a notification.
Useful information to include:
Supporting information
https://2u-internal.atlassian.net/browse/LEARNER-10328
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
ASAP.