Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log correct time and duration for video subsections #36019

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

a-asad
Copy link
Contributor

@a-asad a-asad commented Dec 12, 2024

Description

If a subsection of a video is added to a course using advanced settings, video player shows incorrect time to the user and logs the same time and duration as show to the user, whereas it should log correct time treating the subsection as a standalone video.

Supporting information

It fixes #35928

Testing instructions

  • Check out master/main
  • Add a YouTube video to a course unit and specify a start and end time in advanced settings.
  • Preview the video. You will see the video player showing the start and end times you specified rather it should go from zero till the total duration of the clip.
  • Inspect the event API call using dev tools, you'll notice that the wrong start time and duration are being logged.

Now check out this PR.

  • Refresh the page and play the video again.
  • You should see the correct time values on the video player.
  • Inspect the event API call, you should the correct time and duration.

If a subsection of a video is added to a course using advanced settings, show and log correct start and end times to the users.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 12, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 12, 2024

Thanks for the pull request, @a-asad!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@a-asad a-asad marked this pull request as ready for review December 12, 2024 21:59
Copy link
Contributor

@tecoholic tecoholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a-asad 👍

  • I tested this: Verified that the events sent have relative time and duration values, the player shows duration of the subsection.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Dec 17, 2024
@farhaanbukhsh
Copy link
Member

farhaanbukhsh commented Dec 21, 2024

@a-asad Thank you for the amazing work here, can you squash the commits into a single one and rebase your PR?

Once that is done we can merge it.

@a-asad
Copy link
Contributor Author

a-asad commented Dec 21, 2024

@farhaanbukhsh I've merged master, we can 'squash and merge' here, would be same as squashing manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready to Merge
Development

Successfully merging this pull request may close these issues.

Video player incorrectly reports time/duration for sub-sections of videos
5 participants