-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: log correct time and duration for video subsections #36019
base: master
Are you sure you want to change the base?
Conversation
If a subsection of a video is added to a course using advanced settings, show and log correct start and end times to the users.
Thanks for the pull request, @a-asad! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-asad 👍
- I tested this: Verified that the events sent have relative time and duration values, the player shows duration of the subsection.
- I read through the code
- I checked for accessibility issues
- Includes documentation
@a-asad Thank you for the amazing work here, can you squash the commits into a single one and rebase your PR? Once that is done we can merge it. |
@farhaanbukhsh I've merged master, we can 'squash and merge' here, would be same as squashing manually. |
Description
If a subsection of a video is added to a course using advanced settings, video player shows incorrect time to the user and logs the same time and duration as show to the user, whereas it should log correct time treating the subsection as a standalone video.
Supporting information
It fixes #35928
Testing instructions
event
API call using dev tools, you'll notice that the wrong start time and duration are being logged.Now check out this PR.
event
API call, you should the correct time and duration.