feat: can_redeem checks for enrollment deadline #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
force-pushed
the
aed/can-redeem-enroll-by-date
branch
from
01c1cad to
6ed0686
Compare
iloveagent57
changed the title
iloveagent57
force-pushed
the
aed/can-redeem-enroll-by-date
branch
7 times, most recently
from
bfd9b56 to
e067bb1
Compare
iloveagent57
commented
Aug 15, 2024
| @@ -768,7 +770,7 @@ def can_redeem(self, request, enterprise_customer_uuid): | |||
| enterprise_customer_uuid, lms_user_id, content_key | |||
| ) | |||
|
|
|||
| if not redemptions and not redeemable_policies: | |||
| if not successful_redemptions and not redeemable_policies: | |||
There was a problem hiding this comment.
In local testing, I noticed I wasn't getting any reasons in my test responses even when I can an expected can_redeem=False result. I tend to use reversals a lot to set up test state, so I have many unsuccessful redemptions.
iloveagent57
force-pushed
the
aed/can-redeem-enroll-by-date
branch
from
e067bb1 to
bd0c55f
Compare
We want the `can_redeem` query to return false for a given (user, content key) if the enrollment deadline for the content key is in the past. This is necessary because some courses have runs with an advertised run for which the deadline is in the future, but also have available recent runs where the upgrade deadline is in the past. ENT-7472
iloveagent57
force-pushed
the
aed/can-redeem-enroll-by-date
branch
from
bd0c55f to
689a620
Compare
adamstankiewicz
approved these changes
Aug 15, 2024
| @@ -768,7 +770,7 @@ def can_redeem(self, request, enterprise_customer_uuid): | |||
| enterprise_customer_uuid, lms_user_id, content_key | |||
| ) | |||
|
|
|||
| if not redemptions and not redeemable_policies: | |||
| if not successful_redemptions and not redeemable_policies: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We want the
can_redeemquery to return false for a given (user, content key)if the enrollment deadline for the content key is in the past. This is necessary because
some courses have runs with an advertised run for which the deadline is in the future,
but also have available recent runs where the upgrade deadline is in the past.
Depends on openedx/enterprise-catalog#909 and openedx/enterprise-subsidy#286
A
can_redeemfalse payload for a passed enroll by date will have areasonsvalue like this:Jira:
ENT-7472
Merge checklist:
./manage.py makemigrationshas been runPost merge: