Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for active, current license #596

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: check for active, current license #596

merged 1 commit into from
Nov 25, 2024

Conversation

iloveagent57
Copy link
Contributor

  1. Fix conditional logic.
  2. Change check for an activated license to a check for an activate, current license.

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

pwnage101
pwnage101 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@pwnage101 pwnage101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

adamstankiewicz
adamstankiewicz approved these changes Nov 22, 2024
View reviewed changes
enterprise_access/apps/bffs/handlers.py
Comment on lines +219 to +233
@property
def current_active_license(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call to move this to a @property :) Been thinking it might make sense to do that.

@iloveagent57 iloveagent57 force-pushed the aed/license-status-fixup branch from 802f83e to 5059651 Compare November 22, 2024 20:59
@iloveagent57 iloveagent57 reopened this Nov 25, 2024
@iloveagent57 iloveagent57 merged commit 8bf0d08 into main Nov 25, 2024
5 checks passed
@iloveagent57 iloveagent57 deleted the aed/license-status-fixup branch November 25, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

@pwnage101 pwnage101 pwnage101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iloveagent57 @pwnage101 @adamstankiewicz