Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove expired license status and define EnrollmentDueDateSerializer #602

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

adamstankiewicz
Copy link
Member

Description:

  • Defines EnrollmentDueDate serializer to reflect the specific fields it'd return, if there's a non-empty list (technically a no-op, since the enterprise_course_enrollments API hardcoded an empty list in its response). Opted to be explicit to match the newly defined TypeScript interface on the consuming Learner Portal.
  • Removes expired subscription license status from the BFF serializer/responses since it's not actually a valid license status.

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@adamstankiewicz adamstankiewicz marked this pull request as ready for review November 27, 2024 17:56
@adamstankiewicz adamstankiewicz merged commit dadd558 into main Nov 27, 2024
3 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/bff-serializer-cleanup branch November 27, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants