fix: unittests for default realizations, remove errant break #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
LGTM!
Though, just a quick sanity check - are we good with only testing the auto-enrollment side effects within the test_handlers unit tests versus in the viewset (where we currently have more integration-style tests for the subscription license side effects of license activation and auto-applied licenses)?
I personally don't have strong feelings one way or another; what you have here is totally fine! :)
| @@ -448,8 +448,37 @@ def enroll_in_redeemable_default_enterprise_enrollment_intentions(self): | |||
| if subscription_catalog in applicable_catalog_to_enrollment_intention: | |||
| course_run_key = enrollment_intention['course_run_key'] | |||
| license_uuids_by_course_run_key[course_run_key] = self.current_active_license['uuid'] | |||
| break | |||
There was a problem hiding this comment.
Good catch on the errant break!
iloveagent57
force-pushed
the
aed/unittest-deafult-enrollments
branch
from
847632b to
86f3cff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
breakfrom a loop inenroll_in_redeemable_default_enterprise_enrollment_intentions()Jira:
ENT-9632
Merge checklist:
./manage.py makemigrationshas been runPost merge: