Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't cache if default intentions need enrollment #612

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

iloveagent57
Copy link
Contributor

Description:
We don't want to cache default intentions data if it includes any enrollable intentions, because we don't want to re-attempt enrollment realization on the second of consecutive requests.

Jira:
ENT-9862

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@pwnage101 pwnage101 self-requested a review December 12, 2024 21:18
@iloveagent57 iloveagent57 force-pushed the aed/selectively-cache-intentions branch from c0208fe to 5ba139f Compare December 12, 2024 21:20
@iloveagent57 iloveagent57 force-pushed the aed/selectively-cache-intentions branch from 5ba139f to 29ffaa0 Compare December 13, 2024 14:20
@iloveagent57 iloveagent57 merged commit 214e88e into main Dec 13, 2024
3 checks passed
@iloveagent57 iloveagent57 deleted the aed/selectively-cache-intentions branch December 13, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants