-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more restricted runs and contains_content_items logic #916
Conversation
a18224c
to
df2fec4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM!
df2fec4
to
0fa6ed3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending any test updates (happy to re-review once tests updated).
|
||
any_catalog_contains_content_items = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[kudos] Nice cleanup of any_catalog_contains_content_items
, and only relying on the empty vs. non-empty catalogs_that_contain_course
.
6666727
to
5d81b06
Compare
5d81b06
to
0bdece2
Compare
* contains_content_items endpoint now both utilize the same shared logic around restricted runs * contains_content_items top-level key returns true based on explicit content membership *or* membership in configured restricted runs mapping * The previous point implies that requests about restricted course runs will response with contains_content_items=true, even if the run is not tied directly to the catalog via ContentMetadata records. ENT-9386
0bdece2
to
83bcb90
Compare
Post-review