feat: synchronize restricted courses from discovery #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
force-pushed
the
aed/sync-restricted-courses
branch
from
976fdf3 to
95decdb
Compare
pwnage101
reviewed
Oct 11, 2024
pwnage101
reviewed
Oct 11, 2024
Comment on lines
+847
to
+853
| defaults={ | ||
| '_json_metadata': course_metadata_dict, | ||
| }, |
There was a problem hiding this comment.
shouldn't we just overwrite _json_metadata instead of deferring to the existing one?
There was a problem hiding this comment.
This is what defaults does for update_or_create (and why"defaults" is a poorly-named keyward arg):
The update_or_create method tries to fetch an object from database based on the given kwargs. If a match is found, it updates the fields passed in the defaults dictionary.
https://docs.djangoproject.com/en/4.2/ref/models/querysets/#update-or-create
There was a problem hiding this comment.
:shriek: I fear I've been misusing update_or_create for years now...
iloveagent57
force-pushed
the
aed/sync-restricted-courses
branch
5 times, most recently
from
cd2b1c1 to
50210b6
Compare
iloveagent57
force-pushed
the
aed/sync-restricted-courses
branch
from
50210b6 to
bd8a35f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://2u-internal.atlassian.net/browse/ENT-9570
This is one of two PRs required for the ticket. In this one, we'll deal only with synchronizing top-level restricted courses.
Post-review